[ 
https://issues.apache.org/jira/browse/BIGTOP-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316817#comment-14316817
 ] 

Mark Grover commented on BIGTOP-1640:
-------------------------------------

Sorry for jumping in little late. Looks good but overall, I did notice one 
thing.

We are sed'ing run-examples in install_spark.sh I don't think it's a good idea 
to that long term. In fact, I'd vouch for our spark layout to be more in line 
with the upstream layout. That would eliminate the need for us to use our 
forked spark-classpath.sh and also allow us to movie away from sed'ing specific 
things in the binary scripts (e.g. run-examples).

> Add missing files for Apache Spark
> ----------------------------------
>
>                 Key: BIGTOP-1640
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1640
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: spark
>            Reporter: YoungWoo Kim
>            Assignee: YoungWoo Kim
>             Fix For: 0.9.0
>
>         Attachments: BIGTOP-1640.1.patch, BIGTOP-1640.2.patch, 
> BIGTOP-1640.3.patch
>
>
> Apache Spark package includes shaded assembly jar but there are missing files 
> for Spark's built-on modules.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to