[
https://issues.apache.org/jira/browse/BIGTOP-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334484#comment-14334484
]
Evans Ye commented on BIGTOP-1693:
----------------------------------
Hi [~cos], the patch is in git diff format instead of git format-patch format.
Could you please reformat it?
I didn't test it yet, but I have a comment:
I think we don't need to create '/etc/puppet/modules/stdlib' by ourselves. The
puppet install process will do us the favor. Besides that, it looks like the
{{creates}} in 'install-puppet-stdlib' will prevent stdlib to be actually
installed because the directory has been created by another puppet resource.
> Puppet stdlib should be automatically installed by toolchain
> ------------------------------------------------------------
>
> Key: BIGTOP-1693
> URL: https://issues.apache.org/jira/browse/BIGTOP-1693
> Project: Bigtop
> Issue Type: Improvement
> Components: deployment
> Affects Versions: 0.8.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.9.0
>
> Attachments: BIGTOP-1693.patch, BIGTOP-1693.patch, BIGTOP-1693.patch
>
>
> Right now we have an explicit instruction for a user to install puppet stdlib
> before doing the deployment. This is a bad UX.
> I think the installation should be done in the
> {{bigtop_toolchain::deployment_tools}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
