[ 
https://issues.apache.org/jira/browse/BIGTOP-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355655#comment-14355655
 ] 

RJ Nowling commented on BIGTOP-1744:
------------------------------------

Comments:

1. Tests Pass.  Yay!

2. There is no gradlew script.   Should we change the README to use gradle 
since we don't include the gradlew script? Or do you want to add gradlew?

3. You're using fatjar but other BPS projects (MR, Spark) use shadowJar.  What 
are the advantages / disadvantages of one over the other?

4. Noticed that when I unzipped the distribution created from distZip that it 
has the same jar twice and asks if I want to overwrite. 

5. instructions in README need to be updated for new package paths -- none of 
them work right now.  Dockerfile also needs to be updated because distribution 
zipfile name has changed.

6. Can we include a manifest in the JAR so it can be run more succinctly (java 
-jar path/to/jar parameters...)?

7. Can you add descriptions for the command-line arguments to the README?

8. distZip instructions come first but aren't used -- maybe move them to the 
end and add instructions for running from the distribution zipfile? 

9. Should we add instructions for building and running the Docker container 
locally?  (vs asking users to pull it from your personal account?)

10. I can't get it to run out of the distribution -- fails to find the main 
class.  This also prevents me from running the Docker container I built.

> Add BigPigPetstore File and REST Load Generation.
> -------------------------------------------------
>
>                 Key: BIGTOP-1744
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1744
>             Project: Bigtop
>          Issue Type: New Feature
>          Components: blueprints
>            Reporter: jay vyas
>         Attachments: 13.patch
>
>
> We have an example of using BPS to generate data for spark.
> A more realistic thing, however, which is increasingly important, is 
> streaming data.
> So, I would like to now add in 
> https://github.com/jayunit100/PetStoreLoadGenerator/ as a direct project 
> inside the {{bigtop-bigpetstore}} repository.  Its essentially a way to  
> generate (1) HTTP load or (2) Disk load using the existing BigPetStore data 
> generation algorithm.
> Im tagging this as 0.9, because I think its a great feature to release with.  
>   I can create a patch this week.  It will be a good way, for example, to do 
> scale tests of flume and kafka.
> Open to ideas/opinions on this. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to