Hi Ah indeed if I download https://github.com/apache/bigtop/pull/83.patch again it is updated.
And I see that at least two of my concerns are adressed. Let me review it tomorrow, it's too late now for me. Olaf > Am 05.03.2016 um 23:11 schrieb Faraaz Sareshwala <[email protected]>: > > Hi Olaf, > > I see your confusion. The correct pull requests are: > > https://github.com/apache/bigtop/pull/83 > > https://github.com/apache/bigtop/pull/84 > > https://github.com/apache/bigtop/pull/86 > > > The reason there are two pull requests (and why you might be seeing old code) > is that one was closed out and replaced while renaming branches. Sorry for > the confusion! Let me know if I can help in any other way :). > > Faraaz > > > On 3/5/16, 1:25 PM, "Olaf Flebbe" <[email protected]> wrote: > >> Hi Faraaz, >> >> But how can I get the patch ? There are at least two different pull requests >> numbers mentioned in the JIRA. >> >> Olaf >> >> >>> Am 05.03.2016 um 19:24 schrieb Faraaz Sareshwala >>> <[email protected]>: >>> >>> Hi Olaf, >>> >>> My workflow is to amend my previous commit and force push to my branch. The >>> commit date doesn’t get updated but it is the latest code. I just confirmed >>> that. Github also takes care of updating the pull request with the latest >>> git hash as well when the code updates on my branch. >>> >>> Hope that helps :). Let me know if you have any further questions :). >>> >>> Thanks again for taking a look! >>> >>> Faraaz >>> >>> >>> >>> >>> On 3/5/16, 8:57 AM, "Olaf Flebbe" <[email protected]> wrote: >>> >>>> Sorry Faraaz, >>>> >>>> I do not see any updates on github. Can you direct me to refreshed patches? >>>> >>>> On BIGTOP-2285 I cannot find any useful new information. >>>> The last pull request #83 is from January 14th >>>> https://github.com/fsareshwala/bigtop/commit/d1d6600cacf247567cfe49245c5bfd1ced41ca60 >>>> >>>> Olaf >>>> >>>> >>>> >>>> >>>>> Am 01.03.2016 um 22:48 schrieb Faraaz Sareshwala >>>>> <[email protected]>: >>>>> >>>>> Hi guys, >>>>> >>>>> Could I poke you again to take a look at these patches for me? :) >>>>> >>>>> Thanks! >>>>> >>>>> Faraaz >>>>> >>>>> >>>>> >>>>> On 2/19/16, 5:10 PM, "Faraaz Sareshwala" <[email protected]> >>>>> wrote: >>>>> >>>>>> Thanks for taking a look Roman! >>>>>> >>>>>> All commits are published together on my bigtop fork’s master branch >>>>>> (https://github.com/fsareshwala/bigtop). There are individual branches >>>>>> for each patch as well so that I could make the pull request for each >>>>>> clean. Let me know if you need anything else :). >>>>>> >>>>>> Faraaz >>>>>> >>>>>> >>>>>> >>>>>> On 2/19/16, 4:11 PM, "[email protected] on behalf of Roman >>>>>> Shaposhnik" <[email protected] on behalf of [email protected]> >>>>>> wrote: >>>>>> >>>>>>> Hi Faraaz! >>>>>>> >>>>>>> On Fri, Feb 19, 2016 at 1:51 PM, Faraaz Sareshwala >>>>>>> <[email protected]> wrote: >>>>>>>> I’ve made all the requested changes for the submitted patches. I think >>>>>>>> the puppet recipes >>>>>>>> and smoke tests are pretty much ready to go. Let me know if you guys >>>>>>>> have any comments >>>>>>>> on that. Can someone take a look at the packaging so we can get that >>>>>>>> reviewed and merged? >>>>>>> >>>>>>> Thanks for the contributions! Just to make it easier on reviewers >>>>>>> could you please publish all the required patches in a GH repo? >>>>>>> So I can just pull from there, build and play with your code all at >>>>>>> once. >>>>>>> >>>>>>> Thanks, >>>>>>> Roman. >>>> >>
signature.asc
Description: Message signed with OpenPGP using GPGMail
