Personal preference is merging into one commit. But in this case, I believe it's good to go with preserving the commit history. The history info provides us the details of development and also commits are already reviewed and tested by bigtop members right? :-)
Thanks, Youngwoo 2017. 3. 18. 오전 12:16에 "Roman Shaposhnik" <[email protected]>님이 작성: > Hi! > > as Evans quite rightfully noted right here: > https://issues.apache.org/jira/browse/BIGTOP-2696 > I merged ODPi changes preserving ODPi > commit history. > > Now, assuming that a given change coming from > ODPi looks OK to Bigtop development community, > what would be the preference here? Preserve the > history (this will mean, among other things, commit > messages with ODPi JIRA IDs in them, etc.) OR > squashing everything? > > My rationale for preservation was my obsession with > IP lineage. Basically who contributed what at which > point under which License and ICLA. The downside > is the JIRA IDs and comments in the commits. Btw, > all those JIRAs are public, but of course they have nothing > to do with ASF. > > Thoughts? > > Thanks, > Roman. >
