Oh, I see Olaf already made you a patch in BIGTOP-2751, and is working on BIGTOP-2729, so I think you can focus on the other 3 commits.
2017-04-23 17:27 GMT+08:00 Evans Ye <[email protected]>: > Hi Arnaud, > > Typically to submit a patch I'll create a branch and apply a fix on it. > Then create a PR against bigtop master with [BIGTOP-XXXX] JIRA TITLE > attached as PR's title. > > I see you've cleanly separated each issue into a commit, but it squashed > into one PR. So the things left to do here: > > * Create 5 JIRAs, each for the different issue to fix > * git checkout -b BIGTOP-XXXX to create 5 branches > * Cherry-pick your commit into those branches > * git commit --amend to change the commit message to [BIGTOP-XXXX] JIRA > TITLE > * Push those 5 branches to your forked bigtop git repo > * Create 5 PRs (git will auto-grap the git commit message as PR title) > * DONE > > I'm not quite sure what you knows and what you don't know. So please feel > free to ask so that we can help. :) > > Thanks. > > Evans Ye > > > > > > 2017-04-22 23:51 GMT+08:00 Arnaud Launay <[email protected]>: > >> Le Sat, Apr 22, 2017 at 03:27:29PM +0000, alaunay a écrit: >> > GitHub user alaunay opened a pull request: >> > https://github.com/apache/bigtop/pull/198 >> >> This went sideways... I thought I could create multiple pull >> requests, but the patches I added after that pull were >> automatically added, and are /not/ to be committed (especially >> the Solr stuff). >> >> Should I like undo everything and create branch for each stuff ? >> I've no idea how that works. I find it finally far easier to >> send patches attached to mails :-) >> >> Arnaud. >> > >
