GitHub user kwmonroe opened a pull request:

    https://github.com/apache/bigtop/pull/252

    BIGTOP-2836: charm metric collector race condition

    Ensure `echo 0` is the last thing to run so that the metric hook does not 
cause a failed deployment. Works in all tested scenarios:
    
    False && False || echo 0
    - 0
    
    True && False || echo 0
    - 0
    
    False && True || echo 0
    - 0
    
    True && True || echo 0
    - True

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/juju-solutions/bigtop 
bug/BIGTOP-2836/metric-race

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bigtop/pull/252.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #252
    
----
commit 839891282853684f550385d23775d9e5044f623a
Author: Kevin W Monroe <kevin.mon...@canonical.com>
Date:   2017-07-07T16:55:46Z

    BIGTOP-2836: charm metric collector race condition
    
    Ensure 'echo 0' is the last thing to run so that the metric hook does
    not cause a failed deployment. Works in all tested scenarios:
    
    False && False || echo 0
    - 0
    True && False || echo 0
    - 0
    False && True || echo 0
    - 0
    True && True || echo 0
    - True

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to