Github user kwmonroe commented on a diff in the pull request:

    https://github.com/apache/bigtop/pull/382#discussion_r214485545
  
    --- Diff: bigtop-packages/src/charm/spark/layer-spark/reactive/spark.py ---
    @@ -236,7 +235,8 @@ def reconfigure_spark():
         # Almost all config changes should trigger a reinstall... except when
         # changing the bigtop repo version. Repo version changes require the 
user
         # to run an action, so we skip the reinstall in that case.
    -    if not is_state('config.changed.bigtop_version'):
    +    if not is_state('config.changed.bigtop_version') \
    +            and not is_state('config.changed.spark_enable_thriftserver'):
    --- End diff --
    
    > can you react to a specific config change
    
    yup, you're doing it right :)


---

Reply via email to