Github user kwmonroe commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/400#discussion_r222411244
--- Diff:
bigtop-packages/src/charm/kafka/layer-kafka/lib/charms/layer/bigtop_kafka.py ---
@@ -58,10 +60,14 @@ def configure_kafka(self, zk_units,
network_interface=None):
if network_interface:
ip = Bigtop().get_ip_for_interface(network_interface)
override['kafka::server::bind_addr'] = ip
+ if log_dir:
+ override['kafka::server::log_dirs'] = log_dir
bigtop = Bigtop()
bigtop.render_site_yaml(roles=roles, overrides=override)
bigtop.trigger_puppet()
+ os.makedirs(log_dir, mode=0o700, exist_ok=True)
+ shutil.chown(log_dir, user='kafka')
--- End diff --
These bits should get tucked under the `if log_dir` above, right?
---
