evans-ye commented on a change in pull request #568: BIGTOP-3234: TEZ smoke tests implementation URL: https://github.com/apache/bigtop/pull/568#discussion_r379918195
########## File path: bigtop-tests/smoke-tests/tez/TestTezSmoke.groovy ########## @@ -0,0 +1,86 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p/> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p/> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import org.junit.BeforeClass +import org.junit.AfterClass +import org.apache.bigtop.itest.shell.Shell +import static org.junit.Assert.assertNotNull +import static org.junit.Assert.assertTrue +import org.junit.Test +import org.apache.bigtop.itest.JarContent +import org.apache.bigtop.itest.TestUtils +import org.junit.runner.RunWith + +class TestTezSmoke { + static Shell sh = new Shell("/bin/bash -s"); + + static final String TEZ_HOME = System.getenv("TEZ_HOME"); + static final String HADDOP_CMD = "hadoop jar " + static final String TEZ_EXMP_JAR = TEZ_HOME + "/tez-examples-0.9.1.jar " + static final String TEZ_TEST_JAR = TEZ_HOME + "/tez-tests-0.9.1.jar " + static final String SET_HADOOP_CLASSPATH = "export HADOOP_CLASSPATH=/etc/tez/conf:/usr/lib/tez/*:/usr/lib/tez/lib/*;" Review comment: Yes my thinking is we should fix the bigtop-deploy to set proper tez execution runtime instead of doing it in smoke-test. Do you agree with me? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
