[GitHub] [bigtop] kevinw66 commented on a diff in pull request #968: [WIP]BIGTOP-3766: Add Clang-14

Fri, 29 Jul 2022 01:59:33 -0700 


kevinw66 commented on code in PR #968:
URL: https://github.com/apache/bigtop/pull/968#discussion_r933024974


##########
bigtop_toolchain/manifests/packages.pp:
##########
@@ -63,7 +63,10 @@
         "libffi-devel",
         "krb5-devel",
         "net-tools",
-        "perl-Digest-SHA"
+        "perl-Digest-SHA",
+        "centos-release-scl",
+        "ninja-build",
+        "glibc-devel.i686"

Review Comment:
   @guyuqi When we are compiling llvm in `x86_64` arch, it will also build 
`i686` binary file.
   
![image](https://user-images.githubusercontent.com/31196226/181723825-4f2e21b8-25b0-473c-93ed-54d32cc9224f.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to