docularxu commented on code in PR #1051: URL: https://github.com/apache/bigtop/pull/1051#discussion_r1244565008
########## docker/bigtop-puppet/build.sh: ########## @@ -23,7 +23,6 @@ if [ $# != 1 ]; then echo "Usage: build.sh <PREIX-OS-VERSION>" echo echo "Example: build.sh trunk-centos-7" - echo "openeuler: Example: build.sh trunk-openeuler/openeuler-22.03" Review Comment: No. I mean you submitted two commits which modified the same file, but one added several lines, the other deleted them. Why don't you put these changes into one commit? This adds: https://github.com/apache/bigtop/pull/1051/commits/da5e75519d2110abfcb27fb118eb43affcb14720 This deletes: https://github.com/apache/bigtop/pull/1051/commits/a46e50e432b830907deca32bfdbaf63dabbb1ee7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
