uscxiexing commented on code in PR #1147:
URL: https://github.com/apache/bigtop/pull/1147#discussion_r1295424639


##########
bigtop-deploy/puppet/modules/ambari/manifests/init.pp:
##########
@@ -23,6 +23,39 @@
   }
 
   class server {
+    #install python2 and init postgresql for openEuler
+    if $operatingsystem == 'openEuler' {
+      exec { "download_python2.7":

Review Comment:
   > Python 2.7 would be installed in Bigtop_toolchain: 
https://github.com/apache/bigtop/blob/openEuler-support/bigtop_toolchain/manifests/packages.pp#L395
   > 
   > Please remove the python-2.7 installation from here.
   
   1,Python 2.7 is alrady installed in Bigtop_toolchain. 
   2.   The openeuler was not support python2,and can not find in 
rpm-package-management.so we remove python2 require in openeuler. 
   
![image](https://github.com/apache/bigtop/assets/31821890/f0f1a19a-353a-4974-a294-c4372b9d7035)
   3.  when we use bigtop/puppet to run smoketest,can not find python2 in 
openeuler,and we can not to exec ambari-start or  ambari-agent. so we need to 
instadlled python in openeuler environment,and should add  this python code 
inbigtop-deploy/puppet/modules/ambari/manifests/init.pp
   @guyuqi 
   



##########
bigtop-deploy/puppet/modules/ambari/manifests/init.pp:
##########
@@ -23,6 +23,39 @@
   }
 
   class server {
+    #install python2 and init postgresql for openEuler
+    if $operatingsystem == 'openEuler' {
+      exec { "download_python2.7":

Review Comment:
   > Python 2.7 would be installed in Bigtop_toolchain: 
https://github.com/apache/bigtop/blob/openEuler-support/bigtop_toolchain/manifests/packages.pp#L395
   > 
   > Please remove the python-2.7 installation from here.
   
   1,Python 2.7 is alrady installed in Bigtop_toolchain. 
   2.   The openeuler was not support python2,and can not find in 
rpm-package-management.so we remove python2 require in openeuler. 
   
![image](https://github.com/apache/bigtop/assets/31821890/f0f1a19a-353a-4974-a294-c4372b9d7035)
   3.  when we use bigtop/puppet to run smoketest,can not find python2 in 
openeuler,and we can not to exec ambari-start or  ambari-agent. so we need to 
instadlled python in openeuler environment,and should add  this python code 
inbigtop-deploy/puppet/modules/ambari/manifests/init.pp
   @guyuqi 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to