iwasakims commented on code in PR #1167:
URL: https://github.com/apache/bigtop/pull/1167#discussion_r1330019432


##########
bigtop-packages/src/deb/hive/rules:
##########
@@ -60,6 +60,7 @@ override_dh_auto_install: server2 metastore hcatalog-server 
webhcat-server
        ln -s /usr/lib/hbase/hbase-common.jar /usr/lib/hbase/hbase-client.jar 
/usr/lib/hbase/hbase-hadoop-compat.jar /usr/lib/hbase/hbase-hadoop2-compat.jar 
debian/tmp/usr/lib/hive/lib
        ln -s /usr/lib/hbase/hbase-procedure.jar 
/usr/lib/hbase/hbase-protocol.jar /usr/lib/hbase/hbase-server.jar 
debian/tmp/usr/lib/hive/lib/
        ln -s /usr/lib/zookeeper/zookeeper.jar debian/tmp/usr/lib/hive/lib
+       ln -s /usr/lib/hadoop//tools/lib/hadoop-distcp*.jar 
debian/tmp/usr/lib/hive/lib/

Review Comment:
   You can use environment variable to get the version of Hadoop at least.
   
   ```
   ln -s /usr/lib/hadoop/tools/lib/hadoop-distcp-${HADOOP_VERSION}.jar 
debian/tmp/usr/lib/hive/lib/
   ```
   
   If you want to make the symlink work regardless of Hadoop version, you need 
to make hadoop-distcp.jar as symlink to the hadoop-distcp-x.y.z.jar in Hadoop 
package first. I guess.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to