sekikn commented on PR #1182: URL: https://github.com/apache/bigtop/pull/1182#issuecomment-1763528809
[Your second force-push rewrote HBase version to 2.5.5](https://github.com/apache/bigtop/compare/51c47669e9061d52c293f2b0bb91c4a448df30b6..d6c5fbb0c463587238daaf03f9e7ef0b0cb2f4ee), so the latest PR doesn't work again. ``` $ curl -sL https://github.com/apache/bigtop/pull/1182.diff | git apply $ git diff --stat bigtop-packages/src/common/hbase/patch0-HBASE-27065-2.4.13.diff | 251 ---------------------------------------------------- bigtop.bom | 2 +- 2 files changed, 1 insertion(+), 252 deletions(-) $ git diff bigtop.bom diff --git a/bigtop.bom b/bigtop.bom index 01fbdd7..16141be 100644 --- a/bigtop.bom +++ b/bigtop.bom @@ -162,7 +162,7 @@ bigtop { name = 'hbase' rpm_pkg_suffix = "_" + bigtop.base_version.replace(".", "_") relNotes = 'Apache HBase' - version { base = '2.4.17'; pkg = base; release = 1 } + version { base = '2.5.5'; pkg = base; release = 1 } tarball { destination = "${name}-${version.base}.tar.gz" source = "${name}-${version.base}-src.tar.gz" } url { download_path = "/$name/${version.base}/" $ ./gradlew hbase-clean hbase-pkg ... + cd hbase-2.5.5 + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w . + echo 'Patch #0 (patch2-HBASE-27860-2.4.13.diff):' Patch #0 (patch2-HBASE-27860-2.4.13.diff): + /usr/bin/patch -p1 --fuzz=0 + /usr/bin/cat /home/vagrant/bigtop/build/hbase/rpm/SOURCES/patch2-HBASE-27860-2.4.13.diff patching file hbase-shaded/pom.xml Reversed (or previously applied) patch detected! Assume -R? [n] Apply anyway? [n] Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file hbase-shaded/pom.xml.rej RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.SoZ4qd (%prep) Bad exit status from /var/tmp/rpm-tmp.SoZ4qd (%prep) FAILURE: Build failed with an exception. ``` I'd like you to test your PR locally before asking review, as @iwasakims and @smallyao already pointed out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
