JiaLiangC commented on PR #1214: URL: https://github.com/apache/bigtop/pull/1214#issuecomment-1859370915
@iwasakims I'm sorry for not providing a clear PR description initially. Both BIGTOP-4046 and BIGTOP-4045 are based on BIGTOP-4044, and they both depend on BIGTOP-4044. Therefore, when testing BIGTOP-4046 and BIGTOP-4045, it's necessary to include BIGTOP-4044 in the merge as well. Regarding the patch numbering convention you mentioned, I've also noticed it. However, what has been confusing is that this is a shared patch. If we add a patch number, it means that the names of this patch will be different for all components because the patch numbers will vary. I have also considered another approach, which involves placing this patch in bigtop-packages/src/templates and then copying this patch to the respective build directory after adding the corresponding compilation options. However, there are two drawbacks to this approach: It would require an additional property to control whether the patch needs to be copied to this project because some projects are not Java projects, and some projects do not yet support parallel compilation. This would mean having two properties to control parallel compilation, adding complexity and potentially reducing usability. Considering this, it seems that adding a patch number might be a better choice compared to the second approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
