sekikn commented on code in PR #1238:
URL: https://github.com/apache/bigtop/pull/1238#discussion_r1503391381
##########
bigtop_toolchain/manifests/packages.pp:
##########
@@ -70,7 +70,7 @@
"yasm"
]
- if (/redhat|centos|rocky/ in downcase($operatingsystem) and
Integer($operatingsystemmajrelease) >= 9) {
+ if (0 == versioncmp($operatingsystemmajrelease, '9')) {
Review Comment:
`<=` may be better than `==` considering the future release of new version.
##########
bigtop_toolchain/manifests/packages.pp:
##########
@@ -401,7 +401,7 @@
# download python 2.7.14 for openEuler docker slaves
# and RHEL9 based distros
if $operatingsystem == 'openEuler'
- or (/redhat|centos|rocky/ in $operatingsystem and
Integer($operatingsystemmajrelease) >= 9) {
+ or ($osfamily == 'RedHat' and 0 == versioncmp($operatingsystemmajrelease,
'9')) {
Review Comment:
Same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
