iwasakims commented on code in PR #1242: URL: https://github.com/apache/bigtop/pull/1242#discussion_r1510283061
########## bigtop-packages/src/common/alluxio/install_alluxio.sh: ########## @@ -65,12 +66,15 @@ while true ; do --bin-dir) BIN_DIR=$2 ; shift 2 ;; - --var-dir) - VAR_DIR=$2 ; shift 2 + --var-alluxio-dir) + VAR_ALLUXIO_DIR=$2 ; shift 2 Review Comment: Is this crucial? If we really need this, [rules](https://github.com/apache/bigtop/blob/0f67454a7b71f54b6098ef44cb459e656853a0d7/bigtop-packages/src/deb/alluxio/rules#L39) should be updated too for DEB packaging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@bigtop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org