iwasakims commented on code in PR #1262:
URL: https://github.com/apache/bigtop/pull/1262#discussion_r1582565324
##########
bigtop_toolchain/manifests/packages.pp:
##########
@@ -293,21 +293,10 @@
"python-setuptools",
"libffi-dev",
"python3-dev",
- "python2.7-dev",
"nasm",
"yasm"
]
- if (($operatingsystem == 'Ubuntu' and 0 <=
versioncmp($operatingsystemmajrelease, '22.04'))) {
- file { '/usr/bin/python':
- ensure => 'link',
- target => '/usr/bin/python2',
- }
- $pkgs = $_pkgs
- } elsif (($operatingsystem == 'Ubuntu' and 0 <=
versioncmp($operatingsystemmajrelease, '20.04')) or ($operatingsystem ==
'Debian' and 0 <= versioncmp($operatingsystemmajrelease, '11'))) {
- $pkgs = concat($_pkgs, ["python-is-python2"])
- } else {
- $pkgs = $_pkgs
- }
+ $pkgs = $_pkgs
Review Comment:
We should remove no longer needed temporary `_pkgs` now. @JiaLiangC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
