iwasakims commented on code in PR #1287:
URL: https://github.com/apache/bigtop/pull/1287#discussion_r1672594470
##########
packages.gradle:
##########
@@ -511,7 +521,10 @@ def genTasks = { target ->
// Creating source package
exec {
workingDir DEB_BLD_DIR
+ environment 'PARENT_DIR', FULL_PARENT_DIR
+ environment 'PKG_NAME_SUFFIX', DEB_PKG_NAME_SUFFIX
commandLine "dpkg-buildpackage -uc -us -sa -S".split(' ')
+ environment 'bigtop_base_version', BIGTOP_BASE_VERSION
Review Comment:
formatting nits: the line 527 should be before 526?
##########
packages.gradle:
##########
@@ -382,7 +382,10 @@ def genTasks = { target ->
def final BASE_VERSION = config.bigtop.components[target].version.base
def final SRCDEB = "${PKG_NAME}_$PKG_VERSION-${BIGTOP_BUILD_STAMP}.dsc"
def final HADOOP_VERSION = config.bigtop.components["hadoop"].version.pkg
+ def final FULL_PARENT_DIR = getParentDir(config.bigtop.base_version, "deb")
+ def final DEB_PKG_NAME_SUFFIX =
getPkgNameSuffix(config.bigtop.components[target], "deb").pkgNameSuffix
+ def final BIGTOP_BASE_VERSION = "${config.bigtop.base_version}"
Review Comment:
looks like unintentionally inserted after blank line instead of before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
