kevinw66 commented on code in PR #27: URL: https://github.com/apache/bigtop-manager/pull/27#discussion_r1694607232
########## bigtop-manager-server/src/main/resources/ddl/MySQL-DDL-CREATE.sql: ########## @@ -22,24 +22,49 @@ -- DROP DATABASE IF EXISTS `ambari`; -- DROP USER `ambari`; Review Comment: We can remove this ########## bigtop-manager-server/src/main/resources/ddl/MySQL-DDL-CREATE.sql: ########## @@ -22,24 +22,49 @@ -- DROP DATABASE IF EXISTS `ambari`; -- DROP USER `ambari`; -# delimiter ; +# +delimiter ; -# CREATE DATABASE `bigtop_manager` /*!40100 DEFAULT CHARACTER SET utf8 */; +# CREATE +DATABASE `bigtop_manager` /*!40100 DEFAULT CHARACTER SET utf8 */; # -# CREATE USER 'bigtop_manager' IDENTIFIED BY 'bigdata'; +# CREATE +USER 'bigtop_manager' IDENTIFIED BY 'bigdata'; -# USE @schema; +# +USE @schema; -- Set default_storage_engine to InnoDB -- storage_engine variable should be used for versions prior to MySQL 5.6 -set @version_short = substring_index(@@version, '.', 2); -set @major = cast(substring_index(@version_short, '.', 1) as SIGNED); -set @minor = cast(substring_index(@version_short, '.', -1) as SIGNED); -set @engine_stmt = IF((@major >= 5 AND @minor>=6) or @major >= 8, 'SET default_storage_engine=INNODB', 'SET storage_engine=INNODB'); +set +@version_short = substring_index(@@version, '.', 2); +set +@major = cast(substring_index(@version_short, '.', 1) as SIGNED); +set +@minor = cast(substring_index(@version_short, '.', -1) as SIGNED); +set +@engine_stmt = IF((@major >= 5 AND @minor>=6) or @major >= 8, 'SET default_storage_engine=INNODB', 'SET storage_engine=INNODB'); Review Comment: I think we shouldn't reformat these also ########## bigtop-manager-server/src/main/resources/ddl/MySQL-DDL-CREATE.sql: ########## @@ -22,24 +22,49 @@ -- DROP DATABASE IF EXISTS `ambari`; -- DROP USER `ambari`; -# delimiter ; +# +delimiter ; -# CREATE DATABASE `bigtop_manager` /*!40100 DEFAULT CHARACTER SET utf8 */; +# CREATE +DATABASE `bigtop_manager` /*!40100 DEFAULT CHARACTER SET utf8 */; # -# CREATE USER 'bigtop_manager' IDENTIFIED BY 'bigdata'; +# CREATE +USER 'bigtop_manager' IDENTIFIED BY 'bigdata'; -# USE @schema; +# +USE @schema; Review Comment: New problems here after we reformat these lines -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@bigtop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
