sekikn commented on code in PR #1348:
URL: https://github.com/apache/bigtop/pull/1348#discussion_r2093849406
##########
bigtop_toolchain/manifests/python.pp:
##########
@@ -40,20 +40,24 @@
ensure => present
}
- if ($architecture in ['aarch64']) {
- case $operatingsystem{
- /(?i:(fedora|ubuntu|debian))/: {
- package { 'python2' :
- ensure => present
- }
- }
- /(?i:(centos|redhat|rocky))/: {
- if (versioncmp($operatingsystemmajrelease, '8') == 0) {
- package { 'python2' :
- ensure => present
- }
- }
- }
+ if ($architecture in ['aarch64', 'ppc64le']) {
+ exec { "download_python2.7":
+ cwd => "/usr/src",
+ command => "/usr/bin/wget
https://www.python.org/ftp/python/2.7.18/Python-2.7.18.tgz
--no-check-certificate && /usr/bin/mkdir Python-2.7.18 && /bin/tar -xvzf
Python-2.7.18.tgz -C Python-2.7.18 --strip-components=1 && cd Python-2.7.18",
Review Comment:
For what reason is `--no-check-certificate` required here?
##########
bigtop_toolchain/manifests/python.pp:
##########
@@ -40,20 +40,24 @@
ensure => present
}
- if ($architecture in ['aarch64']) {
- case $operatingsystem{
- /(?i:(fedora|ubuntu|debian))/: {
- package { 'python2' :
- ensure => present
- }
- }
- /(?i:(centos|redhat|rocky))/: {
- if (versioncmp($operatingsystemmajrelease, '8') == 0) {
- package { 'python2' :
- ensure => present
- }
- }
- }
+ if ($architecture in ['aarch64', 'ppc64le']) {
+ exec { "download_python2.7":
+ cwd => "/usr/src",
+ command => "/usr/bin/wget
https://www.python.org/ftp/python/2.7.18/Python-2.7.18.tgz
--no-check-certificate && /usr/bin/mkdir Python-2.7.18 && /bin/tar -xvzf
Python-2.7.18.tgz -C Python-2.7.18 --strip-components=1 && cd Python-2.7.18",
+ creates => "/usr/src/Python-2.7.18",
+ }
+
+ exec { "install_python2.7":
+ cwd => "/usr/src/Python-2.7.18",
+ command => "/usr/src/Python-2.7.18/configure
--prefix=/usr/local/python2.7.18 && /usr/bin/make -j8 && /usr/bin/make install
-j8",
Review Comment:
Just a minor comment, `-j8` doesn't seem optimal always.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
