On 4. Apr, 2013, at 13:49, Gary Martin wrote:

> On 04/04/13 12:07, Apache Bloodhound wrote:
>> #471: Merge activity feed + change history
>> --------------------------+------------------------------------------
>>   Reporter:  jdreimann    |      Owner:  gjm
>>       Type:  enhancement  |     Status:  accepted
>>   Priority:  major        |  Milestone:  Release 6
>>  Component:  dashboard    |    Version:
>> Resolution:               |   Keywords:  ui, comments, change history
>> --------------------------+------------------------------------------
>> 
>> Comment (by matevzb):
>> 
>>  The r1463560 seems to break the newticket page - the ticket form is now
>>  invisible, only the draft preview can be seen. According to the diff, I
>>  gather (not 100% sure) that the form with id "propertyform" was moved
>>  inside a <div py:if="ticket.exists">, which doesn't render when creating a
>>  new ticket.
>> 
> 
> Thanks for spotting that. Just rendering the form in the right hand column 
> will probably look a bit odd so I expect to wrap up that form code into a 
> <py:def> function to allow it to be placed in different areas depending on 
> whether ticket.exists.
> 
> Cheers,
>    Gary

Sounds good. I was also thinking whether it would make sense to split the new 
ticket
page from the view ticket page altogether. As it is now, it's sometimes 
difficult to
move the elements around without running into various issues: (invalid) nested 
forms,
duplicate element IDs, responsive layout breakage etc. Plus it's also more 
difficult
to test all the combinations in current state.

--
matevz

Reply via email to