On 30.04.2013 21:31, Gary Martin wrote:
> Hi,
>
> I found this little problem interesting. I have put a workaround in
> place but I have not gotten around to identifying the underlying cause
> and whether we are likely to see more of these kinds of problem. I
> have left https://issues.apache.org/bloodhound/ticket/512 in a review
> state for now.

Has someone been playing games with class identity? I suspect so ...

In any case I'd store super(x, y).__call__ instead of just the super
reference.

Looking at that code some more, I wonder if it wouldn't be better to
make PATHS_NO_TRANSFORM a frozenset -- the O(n) vs. O(log n) could make
itself felt over time.

Not sure if STATIC_PREFIXES should be a compiled regex instead of a
list; in theory a regex should be faster, but probably not worth it in
this case.

-- Brane

-- 
Branko Čibej
Director of Subversion | WANdisco | www.wandisco.com

Reply via email to