On 5/19/13, Apache Bloodhound <[email protected]> wrote: > #531: Make widget documentation more readable [...] > > Comment (by rjollos): > > Two minor things, > 1. I'm not understanding why we a `py:attrs` attribute is used, in > `widget_doc.html` line 27: > {{{#!python > <h3 py:attrs="{'id': item.get('id')}" class="hblock">${item.title}</h3> > }}} > Are there any cases in which `id` will be `None`? I doesn't look possible > from the way that the `item` dictionary is prepared.
TBH , if you confirm there's no chance for it to be set to `None` (or missing ;) then I have no objections to applying this patch . That code is there since time ago and, afaicr , once upon a time I needed it ... but maybe not anymore . > 1. it might be a small improvement to add a margin so that the title text > doesn't run into the left edge of the background. > > [[Image(after_t531_r1482461_widget_doc_v2.png)]] > > Patch in [attachment:bh531-r1484368.diff]. > > [[Image(after-bh531-r1484368.png)]] > FWIW + -- Regards, Olemis.
