On 5/23/13, Gary Martin <[email protected]> wrote:
> On 22/05/13 18:52, Olemis Lang wrote:
[...]
>>
>> IMO , if <span /> position changes , then just update test cases, thus
>> making this decision obvious by inspecting the test suite . Also
>> beware of the fact that this will cause an extra overhead while
>> performing subsequent merges with Trac trunk .
>>
>> Otherwise , just revert to what they were before .
>>
>> What's more important ? A decision has to be made .
>>
>
> What do you mean? I was advocating reverting the change, partly because
> the change seems to me to be in the wrong place anyway. As far as I am
> concerned asking if the link icon should be on the left or the right of
> the link text is bikeshedding but it is something that is possible to do
> clientside if it is particularly desired.
>
That's exactly my point .
- If the link should be rendered on the right side then
change the code and update test cases to make it
obvious that this is expected behavior .
- If it's better rendered on the left side then keep it just
like it is now .
My point is that keeping it the way it is and then changing its
position using JS code
1. will require extra JS code
* that might also fail
* or interact with other code in the page
* therefore (at least in theory) requiring JS TCs
* ... and that's a subject ... ;)
2. will make the system to diverge from expected behavior
documented in test cases .
3. ... and in the end the goal to do so is to satisfy legacy test cases ,
not to assert expected behavior .
... that's why I suggested to define expected behavior and be
consistent with that when writing / updating test cases .
--
Regards,
Olemis.
