On 7/3/13, Olemis Lang <[email protected]> wrote: > On 7/3/13, Ryan Ollos <[email protected]> wrote: [...] >> >> >> We have a global dashboard, so I think it make sense to also have a >> global >> timeline. I confirm the behavior that `/timeline` redirects to >> `/products/@/timeline`, though I can't say whether this was intentional. >> If >> there are no objections or basis for the current behavior, then I would >> agree with the changes you suggest. >> > > Even after restoring the global timeline there is a more critical > subject ... It seems to be impossible to attach files to global wiki > pages . This is due to the fact that /wiki remains global whereas > /attachment is always redirected to default product . Therefore > attaching a file to a global wiki page will result in > > 1. `SurprisedPhysiological doesn't exist, can't create attachment` > (<= pasted from test report) messages if target wiki page does not > exist in default product scope > 2. File will be attached to the wiki page having the same name > but in default product rather than global scope o.O > > For the time being I'll add a patch in order to **try** to do > something about it. Nonetheless even if all this is (reverted / fixed > / improved) there is another complication regarding functional test > code (and thereby actual system behavior). It is a common practice > throughout Trac's functional test cases to check for successful > actions by inspecting the timeline with filters applied. We have > ticket activity recorded in default product scope and OTOH wiki > activity recorded in global environment. That means that ticket > assertions working now (i.e. resolved in default product scope) will > fail after >
... showing global events at /timeline URL path (... sorry for the previous omission ...) > I hope you will understand if I propose to get rid of redirections to > default product at all > > 1. the resulting URL scheme is confusing > 2. there are annoying consequences , possibly leading to > (invalid / unexpected) content > * e.g. default product = x , user posts in a public ML > URL http://example.com/bh/ticket/33 > referring to ticket 33 in product x ; admin configures default > product = y > and suddenly the URL and content are not related at all . > 3. a lot of complexity is added > 4. maintaining testing code becomes a real headache > * what is fixed under the assumption of interacting with global env > is broken every time interactions involve default product scope > > Just my opinion on this subject based on a few facts . What shall we > do (looking forward to Release 7 as a target) ? > > PS: The issue regarding attachments and global wiki should be > documented in release notes as a known bug . > -- Regards, Olemis.
