On 7/7/13, Ryan Ollos <[email protected]> wrote: > On Sat, Jul 6, 2013 at 10:52 PM, Apache Bloodhound < > [email protected]> wrote: > >> #569: QCT view/edit link can direct to "Error: Invalid ticket number" >> ---------------------------+----------------------- >> Reporter: rjollos | Owner: rjollos >> Type: defect | Status: closed >> Priority: blocker | Milestone: Release 6 >> Component: multiproduct | Version: >> Resolution: fixed | Keywords: qct >> ---------------------------+----------------------- >> >> Comment (by olemis): >> >> Replying to [comment:13 rjollos]: >> > The `base_url` is obtained from the `data-target` attribute of the >> `#qct-create` button. It appears to me that `data-target` will always >> contain the `base_url` for the product in the current scope. >> >> Yes , and that's the way it should always be . >> >> [...] >> > >> > The solution I've implemented is to parse the global `base_url` from >> `data-target` and also pass the `product` to the //ticket create// >> callback. >> >> I'd not recommend to do so because that will not work for custom URL >> deployments e.g. sub-domains. There's no need to use target product >> prefix >> to generate any URL. >> >> > With that information, the proper `href` for the newly created ticket >> can be constructed. >> > >> >> Under certain circumstances ... I'm not sure this will be accurate >> enough. >> >> > Let me know if you see any issues with how I've implemented, or >> possibilities for simplifying it through refactoring. >> >> I'll take a look tomorrow. >> >> -- >> Ticket URL: <https://issues.apache.org/bloodhound/ticket/569#comment:16> >> Apache Bloodhound <https://issues.apache.org/bloodhound/> >> The Apache Bloodhound issue tracker >> > > If you can provide a patch by 12am Eastern Time this evening, I'll test it > out and possibly apply it before the 0.6 release. Otherwise, we'll target > any fixes related to proper construction of the link for product > sub-domains to 0.7 Release. >
I'll submit them in a few minutes ... feel free to schedule it using the right milestone. I've been finishing other patches . -- Regards, Olemis.
