I have patched the translator so it only injects product column into
INSERT statements, if the column was not there already. I have run all
the tests, and they still pass. Is there anything else I should check?
Is there a better alternative approach?

On Tue, Jul 23, 2013 at 10:42 AM, Apache Bloodhound
<[email protected]> wrote:
> #601: ProgrammingError: column "product" specified more than onceLINE 1:
> ...tus,product,severity,keywords,cc,time,changetime, product) V...
> ^
> ---------------------------+--------------------
>   Reporter:  ogaerick      |      Owner:  nobody
>       Type:  defect        |     Status:  new
>   Priority:  blocker       |  Milestone:
>  Component:  multiproduct  |    Version:  0.6.0
> Resolution:                |   Keywords:
> ---------------------------+--------------------
>
> Comment (by astaric):
>
>  For qct, r1505666 removes product from args, so it is never added values
>  dict.
>  {{{
>  if fname in self.values:
>  }}}
>  should therefore prevent it from being added to the INSERT statement.
>
>  Anyway, I have attached a
>  
> [attachment:t601_r1505871_do_not_add_product_column_if_already_exists_in_insert.diff
>  patch] for sql translator, that disables injecting a product if INSERT
>  statement already contains it. Can you check if applying it solves the
>  issue?
>
> --
> Ticket URL: <https://issues.apache.org/bloodhound/ticket/601#comment:10>
> Apache Bloodhound <https://issues.apache.org/bloodhound/>
> The Apache Bloodhound issue tracker

Reply via email to