On Mon, Jul 29, 2013 at 6:36 AM, Gary Martin <[email protected]>wrote:
> (CCing Johannes as I have a suspicion that he is not subscribed to the dev > list.) > > > On 29/07/13 13:45, Johannes Spielmann wrote: > >> Hi, >> >> I've just tried to install BloodHound in the 'de' locale and it wouldn't >> work with this error trace: >> Traceback (most recent call last): >> File "bloodhound_setup.py", line 485, in <module> >> bsetup.setup() >> File "bloodhound_setup.py", line 195, in setup >> translation.activate(locale) >> File >> "/Users/spielmann/prog/**bloodhound/bloodhound/trac/**trac/util/translation.py", >> line 326, in activate >> translations.activate(locale, env_path) >> File >> "/Users/spielmann/prog/**bloodhound/bloodhound/trac/**trac/util/translation.py", >> line 153, in activate >> t.add(Translations.load(**locale_dir, locale or 'en_US', >> AttributeError: 'NullTranslations' object has no attribute 'add' >> >> Changing the rather unusual test in line 149 of >> /trac/trac/util/translation.py to a regular isinstance test seems to fix >> the issue. A patch is attached. >> >> Cheers, >> Johannes >> >> > Thanks for that Johannes. Though this patch is effectively for trac, I > suspect that a lot of our users will experience problems so I am very happy > for you to have brought it up for us. > > In fact, this problem also seems to have turned up on our demo servers > which, up until recently, were building correctly. Seems like we probably > need to look into why this should suddenly be the case. > > Cheers, > Gary > It looks like the issue with the exception not being caught has been fixed in 1.0.2dev: http://trac.edgewall.org/changeset/11783 The ticket is interesting to read, in particular the following comment: http://trac.edgewall.org/ticket/10903#comment:5
