Excellent.. I will have a quick look.

Before I delve too deep, would you like to add the package to the installer/requirements.txt and installer/requirements-dev.txt in your branch to potentially remove a step to work out how to install your plugin?

Also, though it may seem a little pedantic this early, could you add our standard license header to any source files that you have created - that is anything that you have actually written so you should ignore anything from codemirror. We must also not forget to update the NOTICE and LICENSE files with appropriate entries for codemirror's code.

Cheers,
    Gary

On 18/09/13 10:38, Anoop Nayak wrote:
Hi Ryan and all devs,

The scripts are getting included now in the template. I managed to hook it
up all working without disturbing the original template. Please do check it
out. The syntax highlighting is not complete yet but a work in progress.
Will update it soon.

Thanks & Regards,

Anoop Nayak


On Wed, Sep 18, 2013 at 1:20 PM, Anoop Nayak <[email protected]> wrote:

Thanks. I just missed that out entirely :(.


On Wed, Sep 18, 2013 at 1:15 PM, Ryan Ollos <[email protected]>wrote:

On Wed, Sep 18, 2013 at 12:40 AM, Anoop Nayak <[email protected]>
wrote:

Hi Ryan,

I have been trying to make the plugin for a couple of hours before but
seem
to have come across this error:

TypeError: pre_process_request() takes exactly 2 arguments (3 given)

But I have used only 2 arguments in the code i.e as follows
def pre_process_request(req, handler):
         return req, handler

Could you please help me with this?

Thanks & Regards,

Anoop

It's a class method, so you need `self` as the first argument:
def pre_process_request(self, req, handler):



--
Anoop




Reply via email to