2014-03-06 9:47 GMT+01:00 <[email protected]>: > class OneToManyValidator(Validator): > + """Only tree relationships are allowed. A ticket cannot have multiple > + parents.""" > def validate(self, relation): > rls = RelationsSystem(self.env) > - existing_relations = rls._select_relations(relation.source, > - relation.type) > + if relation.type != rls.PARENT_RELATION_TYPE: > + return > + existing_relations = rls._select_relations(relation.destination, > + > rls.CHILDREN_RELATION_TYPE)
I would prefer something like: - existing_relations = rls._select_relations(relation.source, - relation.type) + existing_relations = rls._select_relations(type=relation.type, + destination=relation.destination) (and modified select_relations method so it can also filter by destination). This way, validator would remain reusable.
