On Thu, Mar 13, 2014 at 6:25 AM, Thimal Kempitiya <[email protected]>wrote:
> Hi Ryan, > I added a diff to the issue #789 > > here is the github url https://github.com/thimalk/bloodhound/tree/789 > It would be great if you can give feedback on this. > > > On Wed, Mar 12, 2014 at 6:49 PM, Thimal Kempitiya <[email protected] > >wrote: > > > Hi Ryan, > > Thanks for the suggestions, ticket and feedback. I know you are replying > > to this thread with busy schedule and I very much appreciate that. > > Thanks again for the ticket I start working on that here is the github > > repository on that I didn't do much yet, I currently trying it. > > https://github.com/thimalk/bloodhound-789 > > > > About the DuplicateSearch, my initial thought was to work with > > BloodhoundSearchAPI. What is the difference between the two APIs and > what > > you mean by the "an incremental set of feature, Trac search API first, > then > > BloodhoundSearchAPI." can I please have more clarification on this. > > > > Yeah it would be better to start without the BloodhoundMultiproductPlugin > > at first and then test with with, it would be great if you can help to > run > > bloodhound without the Bloodhound multiproduct environment. > > > > As the student proposal period is started it would be great if you can > > give advise on the proposal. Is there specific things that you expect and > > also is there any sample proposals related to bloodhound project that we > > can get idea > > > > > > On Tue, Mar 11, 2014 at 2:16 PM, Ryan Ollos <[email protected] > >wrote: > > > >> On Thu, Mar 6, 2014 at 6:47 AM, Thimal Kempitiya <[email protected] > >> >wrote: > >> > >> > Thanks Ryan, > >> > > >> > I have basic knowledge in jQuery and I'm familiarizing with boostrap > and > >> > jQuery these days as you suggested. It would be great if you can > suggest > >> > related starter ticket for me to familiarize with the code base > >> > > >> > form your ideas and with my thoughts I came up with this, please > >> correct me > >> > if need changes or fixes > >> > > >> > As you said need three components > >> > KeywordSuggest > >> > suggest keywords in the existing tickets and suggest them in order > of > >> the > >> > frequency use( or alphabetical order) > >> > This need to suggest list of keywords when there is no characters > are > >> > entered with press of enter key (or any other combination) as new > >> users > >> > can get suggestion about the appropriate keywords to use > >> > Need to suggest keywords without case sensitivity as no need create > new > >> > keywords with same name and capital or simple letters. > >> > > >> > DuplicateTicketSearch > >> > This show list of related ticket based on the summary field > >> > This suggestion need to have maximum limit (5) > >> > It will search related ticket based on the words entered in summary > >> field > >> > (if possible need extend this to check with the description field, but > >> need > >> > to check the performance) > >> > > >> > AutocompleteUsers > >> > This will be related to the Cc field and Owner fields > >> > suggest based on the existing users > >> > (I have doubt this need to give list of users without entering any > >> > character as users need to know existing users) > >> > > >> > > >> > * KeyowrdSuggest and AutocompleteUsers components need to suggest > >> keywords > >> > and users with one character > >> > * I think all three components need to retrieve from server side > >> > dynamically as need to have common word bases > >> > (need to check the performance as this approach will take more time > >> than > >> > getting words locally) > >> > *All three components need have database access > >> > > >> > > >> > Can I know about the possibility of getting keywords with the > frequency > >> of > >> > use > >> > Is the database struture is same as the trac > >> > where I can get more detail about database access and structure of > >> schema > >> > >> > >> Hi Thimal, > >> > >> I apologize for the delay in my reply. Ticket #789 (1) might be a good > >> starter ticket so that you can become more familiar with Bootstrap. I'll > >> essentially be repeating here what I suggested to Devender in a thread > >> yesterday (for a ticket different than yours): > >> > >> 1. Review the Bootstrap 2.3 documents (2) > >> 2. Copy the template trac/ticket/templates/roadmap.html to > >> bloodhound_theme/bhtheme/templates/bh_roadmap.html (I already did this > >> step > >> for you) > >> 3. Add bh_roadmap.html to the template map in > >> bloodhound_theme/bhtheme/theme.py > >> 4. Modify the markup in the template so that we get nice styling on > >> multiple devices (desktop, tablet, mobile). > >> > >> The requirements that you've come up with so far look good to me. I like > >> your idea of ordering by frequency of use. One additional consideration > >> for > >> DuplicateSeach is whether it will work with the Trac search API, the > >> BloodhoundSearchPlugin, or both. You might propose an incremental set of > >> feature, Trac search API first, then BloodhoundSearchAPI. > >> > >> The database structure is essentially the same for Bloodhound as it is > for > >> Trac, and we don't have any Bloodhound-specific database documentation. > >> Bloodhound adds a product column to some tables, but that is the most > >> significant change. > >> > >> Given the complications of the Bloodhound multiproduct environment, it > >> wouldn't be a bad idea to do the initial development against a Trac > >> environment without the BloodhoundMultiproductPlugin. You'd probably > still > >> want to develop with the BloodhooundTheme, as your client-side code > might > >> be integrated directly into the theme (but that's for you to decide). > I'll > >> need to do some testing to make sure that it's possible to use > Bloodhound > >> without BlooodhoundMultiproduct. The Bloodhound plugins have a tendency > to > >> acquire dependencies on one another since we don't do any testing to > >> ensure > >> they work standalone. I'll make that an action item for the coming days > >> and > >> get back to you. > >> > >> (1) https://issues.apache.org/bloodhound/ticket/789 > >> (2) http://getbootstrap.com/2.3.2/ > Nice work. I committed after some additional changes. Here are some hints for going forward: - Don't remove or change the "id" and "name" attributes, since they'll be needed for executing the functional test suite, and we don't want to rewrite Trac functional test cases when we aren't forced to. - In many cases we'll be need to maintain these by comparing them to a Trac template after a new Trac version is integrated, therefore we aim to make only the necessary modifications (e.g. no unnecessary indentation changes). - Please configure your editor to convert tabs to spaces, and give the Trac style guide a quick read: http://trac.edgewall.org/wiki/TracDev/CodingStyle It's likely that more tweaks will be needed to improve the layout and display across devices. For now I went ahead and committed the changes since they are an improvement. Please submit additional patches if you have additional changes to propose. Thanks!
