On Tue, Apr 1, 2014 at 11:24 PM, Apache Bloodhound < [email protected]> wrote:
> #795: request_factory and environment_factory options point to files in the > bloodhound source directory > ------------------------+----------------------- > Reporter: rjollos | Owner: rjollos > Type: defect | Status: accepted > Priority: major | Milestone: Release 8 > Component: installer | Version: > Resolution: | Keywords: > ------------------------+----------------------- > Changes (by rjollos): > > * status: new => accepted > > > Comment: > > Proposed change is to use a fully-qualified name for `[trac] > environment_factory` and `[trac] request_factory`. Patch in > [attachment:t795.diff]. > > `load_class` is from SO:547867/121694, with exception handling added. > > -- > Ticket URL: <https://issues.apache.org/bloodhound/ticket/795#comment:1> > Apache Bloodhound <https://issues.apache.org/bloodhound/> > The Apache Bloodhound issue tracker > I will wait until Friday for feedback before committing this change. We could potentially look at a more serious reworks of the hooks code, but I'm not ready to work on that now. The other issue is that we will likely end up with a manual step in the upgrade to 0.8, unless we add an upgrade step, and an upgrade step can only reasonably handle the case that the user hasn't modified the `[trac] request_factory` and `[trac] environment_factory` from their defaults. The upgrade step could go in bloodhound_multiproduct, but doesn't really belong there. We don't want to start adding our own upgrade steps in our copy of the Trac core because we'll end up with conflicts when pulling in new versions.
