[
https://issues.apache.org/jira/browse/BOOKKEEPER-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14314678#comment-14314678
]
Hadoop QA commented on BOOKKEEPER-837:
--------------------------------------
Testing JIRA BOOKKEEPER-837
Patch
[001-BOOKKEEPER-837.patch|https://issues.apache.org/jira/secure/attachment/12697826/001-BOOKKEEPER-837.patch]
downloaded at Tue Feb 10 18:26:40 UTC 2015
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
120
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:green}+1 TESTS{color}
. Tests run: 949
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/898/
> UpdateLedgerOp - Replace AbstractFuture with SettableFuture
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-837
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-837
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery, bookkeeper-client,
> bookkeeper-server
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.3.1
>
> Attachments: 001-BOOKKEEPER-837.patch
>
>
> +Review comment :+ Using AbstractFuture is too tight with guava's internal
> implementation. Instead it would be good to use a variable for the settable
> future.
> {code}
> class Read... implements GenericCallback {
> SettableFuture future = ...;
> public void operationComplete(..) {
> future.set(null);
> // future.setException(..)
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
