[
https://issues.apache.org/jira/browse/BOOKKEEPER-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003506#comment-15003506
]
Jiannan Wang commented on BOOKKEEPER-877:
-----------------------------------------
Ignore my last comment, it's auto-generated during playing script.
Cool script! Some comments:
* To save time, it would be better to document somewhere about how to use it:
** *pip install jira rbtools*
** run *rbt setup-repo* under bookkeeper git repo directory
* Compare with original script, the git_command uses *git diff* instead of *git
format-patch*. As a result, binary file diff and some meta-information is
missing, see
http://stackoverflow.com/questions/4624127/what-is-the-difference-between-git-format-patch-and-git-diff.
> Script for generating patch for reviews
> ---------------------------------------
>
> Key: BOOKKEEPER-877
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-877
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Attachments: BOOKKEEPER-877.patch,
> BOOKKEEPER-877_2015-11-12_00:26:23.patch,
> BOOKKEEPER-877_2015-11-12_00:28:08.patch,
> BOOKKEEPER-877_2015-11-12_00:52:03.patch
>
>
> It would be good to have a script to generate patch for reviews.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
