[ https://issues.apache.org/jira/browse/BOOKKEEPER-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124969#comment-15124969 ]
ASF GitHub Bot commented on BOOKKEEPER-879: ------------------------------------------- Github user fpj commented on a diff in the pull request: https://github.com/apache/bookkeeper/pull/2#discussion_r51347435 --- Diff: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java --- @@ -351,7 +364,12 @@ public static LedgerMetadata parseConfig(byte[] bytes, Version version) throws I LedgerMetadataFormat.Builder builder = LedgerMetadataFormat.newBuilder(); TextFormat.merge(reader, builder); LedgerMetadataFormat data = builder.build(); - lc.writeQuorumSize = data.getQuorumSize(); + lc.writeQuorumSize = data.getQuorumSize(); + if (data.hasCtime()) { + lc.ctime=data.getCtime(); --- End diff -- Space around "=" sign to be consistent across the code. > Record ledger creation time > --------------------------- > > Key: BOOKKEEPER-879 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-879 > Project: Bookkeeper > Issue Type: New Feature > Components: bookkeeper-client, bookkeeper-server > Affects Versions: 4.3.1 > Reporter: Enrico Olivelli > Fix For: 4.4.0 > > > I think that a creation timestamp would be very useful and it does not cost > very much. It would be an immutable value. > Nowadays (on 4.3.1) I must keep that info together with the id of the ledger, > for instance in zookeeper, but if that reference gets lost there is now way > to know how old a ledger is. > I think that this timestamp should be captured on client while calling > createLedger or asyncCreateLedger. > In addition to this very common field maybe it would be useful to add a > custom byte[] field named "custom client data" in order to let the client > 'describe' the ledger without the need of extra data on Zookeeper. -- This message was sent by Atlassian JIRA (v6.3.4#6332)