[
https://issues.apache.org/jira/browse/BOOKKEEPER-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15650898#comment-15650898
]
ASF GitHub Bot commented on BOOKKEEPER-966:
-------------------------------------------
GitHub user jiazhai opened a pull request:
https://github.com/apache/bookkeeper/pull/75
BOOKKEEPER-966: change bookieServer cmdline to make conf-file and option
co-exist
Currently, when using bookieServer cmdline to start a bookie, you will
either give it a cofiguration file by "-c booke.conf"; or add some options like
"<bookie_port> <zk_servers> <journal_dir> <ledger_dir [ledger_dir]>" in a fix
sequential.
It may not satisfy some of the requirement. So changed it to be co-exist
for configuration file and options.
By this change, it will first use settings in configuration file; and then
use options to overwrite some of the settings, if there are some options
provided.
Here is an example after this change:
```
BookieServer -c bookie.conf -z localhost:2181 -m /bookkeeper/ledgers -p
3181 -j /mnt/journal -l "/mnt/ledger1 /mnt/ledger2 /mnt/ledger3”
```
Here, in this command:
-z is for “Zookeeper client instance”;
-m is for "Zookeeper ledgers root path for bookies";
-p is for "bookie service port exported";
-j is for "bookie journal directory";
-l is for "bookie ledgers directories".
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jiazhai/bookkeeper-1 BOOKKEEPER-966
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/75.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #75
----
commit ba1c99f6829b4479e10b02fc1e4e368b8dd178df
Author: jiazhai <[email protected]>
Date: 2016-11-09T07:46:26Z
Merge pull request #1 from apache/master
catch up with parent stream at 11_9
commit 73c39f296e887279577b67e659935557209af912
Author: jiazhai <[email protected]>
Date: 2016-11-09T09:40:59Z
change bookieServer cmdline to make conf-file and option co-exist
----
> change the bookieServer cmdline to make conf-file and option co-exist
> ---------------------------------------------------------------------
>
> Key: BOOKKEEPER-966
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-966
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Jia Zhai
> Assignee: Jia Zhai
>
> Currently, when using bookieServer cmdline to start a bookie, you will either
> give it a cofiguration file by "-c booke.conf"; or add some options like
> "<bookie_port> <zk_servers> <journal_dir> <ledger_dir [ledger_dir]>" in a fix
> sequential.
> It may not satisfy some of the requirement. So changed it to be co-exist for
> configuration file and options.
> By this change, it will first use settings in configuration file; and then
> use options to overwrite some of the settings, if there are some options
> provided.
> Here is an example after this change:
> BookieServer -c bookie.conf -z localhost:2181 -m /bookkeeper/ledgers -p 3181
> -j /mnt/journal -l "/mnt/ledger1 /mnt/ledger2 /mnt/ledger3”
> Here, in this command:
> -z is for “Zookeeper client instance”;
> -m is for "Zookeeper ledgers root path for bookies";
> -p is for "bookie service port exported";
> -j is for "bookie journal directory";
> -l is for "bookie ledgers directories".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
