Would it be a good idea to add a "mvn clean install findbugs:check rat:check -DskipTests " in the merge script ?
IMHO it will cover 99% of the recent problems on the QA jobs (findbugs and rat complaints) Sometimes the PR checker fails due to a flaky test and then findbugs and rat are not executed. We can also investigate if there is a way to run findbugs and rat event in case of test failures, maybe with a "Post build action" 2017-01-16 17:19 GMT+01:00 Sijie Guo <si...@apache.org>: > Enrico, > > I think the current pull request check should catch the findbugs warnings. > I think we might didn't check the check job result carefully before > merging. Currently the merge script is not enforced to check the ci job's > result. We can try to improve this part. I believe github should have API > to check these things. > > - Sijie > > On Sun, Jan 15, 2017 at 11:25 PM, Enrico Olivelli - Diennea < > enrico.olive...@diennea.com> wrote: > > > Hi, > > current master has an annoying findbugs error > > > > [INFO] Total bugs: 1 > > [INFO] org.apache.bookkeeper.bookie.BookieShell$FilesTimeComparator > > implements Comparator but not Serializable [org.apache.bookkeeper.bookie. > > BookieShell$FilesTimeComparator] At BookieShell.java:[lines 1827-1851] > > SE_COMPARATOR_SHOULD_BE_SERIALIZABLE > > [INFO] > > > > > > should I create a new JIRA for this or the fix will jump in on next > > "merge" ? > > > > can we add some additional check to the merge procedure in order to > > prevent findbugs and rat errors on master ? > > > > this kind of errors break the automatic QA jobs > > > > ideas ? > > > > > > > > -- > > > > Enrico Olivelli Software Development Manager @Diennea Tel.: (+39) 0546 > > 066100 - Int. 925 Viale G.Marconi 30/14 - 48018 Faenza (RA) MagNews - > > E-mail Marketing Solutions http://www.magnews.it Diennea - Digital > > Marketing Solutions http://www.diennea.com > > > > ________________________________ > > > > Iscriviti alla nostra newsletter per rimanere aggiornato su digital ed > > email marketing! http://www.magnews.it/newsletter/ > > > > The information in this email is confidential and may be legally > > privileged. If you are not the intended recipient please notify the > sender > > immediately and destroy this email. Any unauthorized, direct or indirect, > > disclosure, copying, storage, distribution or other use is strictly > > forbidden. > > >
