[ https://issues.apache.org/jira/browse/BOOKKEEPER-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858083#comment-15858083 ]
ASF GitHub Bot commented on BOOKKEEPER-999: ------------------------------------------- GitHub user revans2 opened a pull request: https://github.com/apache/bookkeeper/pull/105 BOOKKEEPER-999: Stop leaking threads in BookKeeper client You can merge this pull request into a Git repository by running: $ git pull https://github.com/revans2/bookkeeper BOOKKEEPER-999 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bookkeeper/pull/105.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #105 ---- commit b0e9a3679f76771e80cefbe67de7a1ed33fc42ad Author: Robert (Bobby) Evans <ev...@yahoo-inc.com> Date: 2017-02-08T14:45:30Z BOOKKEEPER-999: Stop leaking threads in BookKeeper client ---- > BookKeeper client can leak threads > ---------------------------------- > > Key: BOOKKEEPER-999 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-999 > Project: Bookkeeper > Issue Type: Bug > Components: bookkeeper-client > Affects Versions: 4.4.0 > Reporter: Robert Joseph Evans > Assignee: Robert Joseph Evans > > The client constructor > {{BookKeeper(ClientConfiguration conf, ZooKeeper zk)}} > in 4.4 and above will create a new NioClientSocketChannelFactory but does not > set the ownership of that factory to true so threads are leaked. > This showed up as a failure in BookieRecoveryTest on MacOS where it has a > hard coded limit of about 2000 threads in a single process, and this test was > going beyond that. -- This message was sent by Atlassian JIRA (v6.3.15#6346)