[
https://issues.apache.org/jira/browse/BOOKKEEPER-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894765#comment-15894765
]
ASF GitHub Bot commented on BOOKKEEPER-1004:
--------------------------------------------
GitHub user govind-menon reopened a pull request:
https://github.com/apache/bookkeeper/pull/109
BOOKKEEPER-1004: Allow bookie garbage collection to be triggered manu…
Ran CompactionTest#testForceGarbageCollection
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/govind-menon/bookkeeper BOOKKEEPER-1004
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/109.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #109
----
commit b17d3529d49d91d9a7922af23dc308e97fd9892c
Author: Govind Menon <[email protected]>
Date: 2017-02-14T18:06:44Z
BOOKKEEPER-1004: Allow bookie garbage collection to be triggered manually
from tests
Originally done by Ivan Kelly
The current gc tests rely on waiting on a timeout for gc to run. It's
never certain whether it has run or not or if it's still running.
This patch allows tests to trigger a gc run and gives the client
a future to know when it has completed. I haven't changed the gc
algorithm, but now it runs in a scheduled executor rather than as a
Thread.
BOOKKEEPER-1004: Allow bookie garbage collection to be triggered manually
from tests
Originally done by Ivan Kelly
The current gc tests rely on waiting on a timeout for gc to run. It's
never certain whether it has run or not or if it's still running.
This patch allows tests to trigger a gc run and gives the client
a future to know when it has completed. I haven't changed the gc
algorithm, but now it runs in a scheduled executor rather than as a
Thread.
----
> Allow bookie garbage collection to be triggered manually from tests
> -------------------------------------------------------------------
>
> Key: BOOKKEEPER-1004
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1004
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Affects Versions: 4.5.0, 4.6.0
> Reporter: Govind Menon
> Priority: Minor
> Labels: test
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The current gc tests rely on waiting on a timeout for gc to run. It's
> never certain whether it has run or not or if it's still running.
> This patch allows tests to trigger a gc run and gives the client
> a future to know when it has completed. The gc algorithm is unchangedI but
> now it runs in a scheduled executor rather than as a
> Thread.
> This work was originally done by Ivan Kelly and I am just pushing it back to
> open source
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
