[ https://issues.apache.org/jira/browse/BOOKKEEPER-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006717#comment-16006717 ]
ASF GitHub Bot commented on BOOKKEEPER-1057: -------------------------------------------- Github user jvrao commented on the issue: https://github.com/apache/bookkeeper/pull/145 On Thu, May 11, 2017 at 8:09 AM Matteo Merli <notificati...@github.com> wrote: > @jvrao <https://github.com/jvrao> I agree with the point of separating > the recovery vs non-recovery. > > At yahoo we were using log sniffer to get alerts from all error messages. > If an error message is not symptom of something wrong that require some > operator action, then it only adds to noise. > > In the specific, since you cannot distinguish, just by seeing this error > messages, whether something was *really* wrong or everything is ok.. the > error message is not useful. > > That's exactly my point. Can we use this opportunity to do the right fix instead of masking real errorcases? — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/bookkeeper/pull/145#issuecomment-300819767>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAChroDChR08-PSMdZ4oatC0P1N9Brgcks5r4yTGgaJpZM4NXBv9> > . > -- Sent from iPhone > Do not log error message after read failure in PendingReadOp > ------------------------------------------------------------ > > Key: BOOKKEEPER-1057 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1057 > Project: Bookkeeper > Issue Type: Task > Reporter: Matteo Merli > Assignee: Matteo Merli > Priority: Trivial > Fix For: 4.5.0 > > > In {{PendingReadOp}}, there is an error message that is printed each time a > read on a specific bookie is failing: > {noformat} > LOG.error("Read of ledger entry failed: L{} E{}-E{}, Heard from {}. First > unread entry is {}", > new Object[] { lh.getId(), startEntryId, endEntryId, heardFromHosts, > firstUnread }); > {noformat} > This message is getting printed each time a ledger is recovered and there is > no error, since the ledger recovery logic is to keep reading and incrementing > the entryId until a NoEntry error is received. > This log message should be set at debug level. -- This message was sent by Atlassian JIRA (v6.3.15#6346)