Github user eolivelli commented on the issue:

    https://github.com/apache/bookkeeper/pull/180
  
    @sijie I did a more deep review and it is all great for me.
    
    Do you think it would be useful to add a test for  readUnconfirmedEntries ? 
Actually the implementation is shared with readEntries so maybe we can live 
without such new test
    
    b.q. Just to understand better  
    How are you using this feature to improve speed of "tailing reads" ? I see 
that the LAC is advanced without calling readLastAddConfirmed but there is no 
guarantee that it will actually advance so sometimes you will need to call 
readLastAddConfirmed anyway, isn't it ?.
    How can you distinguish the case of dead writer/no more data/closed ledger 
? by catching exceptions ?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to