[
https://issues.apache.org/jira/browse/BOOKKEEPER-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044344#comment-16044344
]
ASF GitHub Bot commented on BOOKKEEPER-1093:
--------------------------------------------
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/180
@sijie I did a more deep review and it is all great for me.
Do you think it would be useful to add a test for readUnconfirmedEntries ?
Actually the implementation is shared with readEntries so maybe we can live
without such new test
b.q. Just to understand better
How are you using this feature to improve speed of "tailing reads" ? I see
that the LAC is advanced without calling readLastAddConfirmed but there is no
guarantee that it will actually advance so sometimes you will need to call
readLastAddConfirmed anyway, isn't it ?.
How can you distinguish the case of dead writer/no more data/closed ledger
? by catching exceptions ?
> Piggyback LAC on ReadResponse
> -----------------------------
>
> Key: BOOKKEEPER-1093
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1093
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-client, bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.5.0
>
>
> Currently LAC is only updated when the reader explicitly calls
> #readLastAddConfirmed(). In tailing-read use cases, it will not wise to keep
> calling #readLastAddConfirmed, especially when the traffic is huge.
> The idea here is piggy-back LAC along with the read responses. so the client
> will get advanced LAC along with read responses. so it will reduce calling
> #readLastAddConfirmed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
