jvrao commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication URL: https://github.com/apache/bookkeeper/pull/189#issuecomment-311665630 @sijie @reddycharan Let me step back and discuss this. 1. Are there any legitimate use cases of specifying multiple ledger dirs on the same disk partition? if not, in production I would like to flag this as error, or at least a warning to ignore other ledger dirs. I don't think code need to work hard to dedup and skip these things. This is not a naive user mistake, configurations are done by system administrator and they need to be crisp IMO. 2. Currently we have only one active entrylog, so having multiple dirs on the same disk, at the most may fill one disk partition faster/quicker than other. (Say three ledger dirs on disk1 and one ledger dir on disk2). If disk1 and disk2 are of same sizes, disk1 gets used more. but if disk1 is bigger than disk2 then this feature may be handy. 3. When we move to multiple active entrylogs, we are going to distribute entrylogs across ledger dirs. When this feature is introduced it surely hits perf because one disk may be having multiple entrylogs which gets written/scyned unless dedup is implemented. @sijie I am not sure what is the biggest concern about this. Are you worried about too many configuration parameters? or something else? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
