GitHub user sigee opened a pull request: https://github.com/apache/bookkeeper/pull/217
Code cleanups Descriptions of the changes in this PR: There are some different kind of cleanups by commits. To make the code more readeable and improve code quality and improve performance in some cases. E.g.: - Remove unnecessary semicolons - Remove unused/unneeded/duplicated imports - Replace l to L in long literals - Remove boxing on an already boxed value - Replace iterations to bulk operations --- Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `<Issue # or BOOKKEEPER-#>: Description of pull request` `e.g. Issue 123: Description ...` `e.g. BOOKKEEPER-1234: Description ...` - [ ] Make sure tests pass via `mvn clean apache-rat:check install findbugs:check`. - [ ] Replace `<Issue # or BOOKKEEPER-#>` in the title with the actual Issue/JIRA number. --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/sigee/bookkeeper cleanups Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bookkeeper/pull/217.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #217 ---- commit 94741df4ffbe884b70ec31188c77d46750f8378b Author: sigee <sige...@gmail.com> Date: 2017-06-29T09:07:51Z Remove unnecessary semicolons commit 99df3dc8f4182756f57e7ca07003e68e8b329f95 Author: sigee <sige...@gmail.com> Date: 2017-06-29T09:15:24Z Symplify if statements commit 88da9fe7dc9b6e2682d92dc9bf39e5cf4693376e Author: sigee <sige...@gmail.com> Date: 2017-06-29T10:23:31Z Use static member statically commit 2bb697c53ee6dab82dfff03b7f24bac4c0c12ae0 Author: sigee <sige...@gmail.com> Date: 2017-06-29T12:52:20Z Remove unused/unneeded/duplicated imports commit bbb957621fd1a6939a9925a431901e9b8e15efdd Author: sigee <sige...@gmail.com> Date: 2017-06-29T13:09:55Z Replace l to L in long literals commit 507a1ae4ba28b7bca324a9317cc0880f021b6280 Author: sigee <sige...@gmail.com> Date: 2017-06-29T13:11:41Z Remove boxing on an already boxed value commit 12c96488141ddd22afb5f4deb1394cf7373c1fcb Author: sigee <sige...@gmail.com> Date: 2017-06-29T13:14:30Z Replace manual array to collection to Collection.addAll() commit 41c18840b5236b1bd2e9dccbaf654df37b1b6ff8 Author: sigee <sige...@gmail.com> Date: 2017-06-29T13:17:52Z Remove redundant String constructor call commit 6934fabee27beaf00876f9884a2a5344ecaa4ee3 Author: sigee <sige...@gmail.com> Date: 2017-06-29T13:21:40Z Replace iterations to bulk operations ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---