eolivelli opened a new issue #241: Merge script does not deal well with non-ascii names of reviewers URL: https://github.com/apache/bookkeeper/issues/241 - What did you do? There is an error in the bk-merge-pr.py script in case of reviewers with non-ascii characters in name - What did you expect to see? the merge script should run without errors - What did you see instead? see comments in #239 from @jiazhai ``` (master) python dev/bk-merge-pr.py git rev-parse --abbrev-ref HEAD Which pull request would you like to merge? (e.g. 34): 240 Traceback (most recent call last): File "dev/bk-merge-pr.py", line 555, in <module> main() File "dev/bk-merge-pr.py", line 466, in main pr_reviewers = get_reviewers(pr_num) File "dev/bk-merge-pr.py", line 450, in get_reviewers reviewers_emails.append('{0} <{1}>'.format(username, useremail)) UnicodeEncodeError: 'ascii' codec can't encode character u'\xe1' in position 1: ordinal not in range(128) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services