caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r127238474
########## File path: docker/4.4.0-alpine/Dockerfile ########## @@ -0,0 +1,59 @@ +FROM java:openjdk-8-jre-alpine +MAINTAINER Francesco Caliumi <francesco.cali...@gmail.com> + +# Install required packages +RUN apk add --no-cache \ + bash \ + su-exec + +ENV ZK_SERVERS= \ + BK_USER=bookkeeper \ + BK_PORT= \ Review comment: Blank is the default so it let the run.sh script to know that the env variable has not been set by "docker run" and let the config file original value. I'm fine anyway in providing a default here with documentation purpose. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
