caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r127412474
########## File path: docker/4.4.0-alpine/Dockerfile ########## @@ -0,0 +1,59 @@ +FROM java:openjdk-8-jre-alpine +MAINTAINER Francesco Caliumi <francesco.cali...@gmail.com> + +# Install required packages +RUN apk add --no-cache \ + bash \ + su-exec + +ENV ZK_SERVERS= \ + BK_USER=bookkeeper \ + BK_PORT= \ Review comment: @sijie @jiazhai I remembered the reason behind this implementation. We provide to docker user the ability to mount configurations file at run time. These files will be rewritten with the env variables set at run. If we do provide a default for the port, in run.sh we have no way to determine if was passed by the user or it's the default, so it will be rewritten in each case, overwriting the port specified by the user in conf file. I will restore the BK_PORT=[blank] and BK_BUILD_PORT ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
