jiazhai commented on issue #241: Merge script does not deal well with non-ascii names of reviewers URL: https://github.com/apache/bookkeeper/issues/241#issuecomment-315324040 @eolivelli, thanks a lot for the info, have a try on 234 with a fix, and it passed: ``` git:(issue_241) python dev/bk-merge-pr.py git rev-parse --abbrev-ref HEAD Which pull request would you like to merge? (e.g. 34): 234 Commit title [Issue 230: Add Checkstyle to the build process (Part 2)]: I've re-written the title as follows to match the standard format: Original: Issue 230: Add Checkstyle to the build process (Part 2) Modified: ISSUE #230: Add Checkstyle to the build process (Part 2) Would you like to use the modified title? (y/n): y Using modified title: ISSUE #230: Add Checkstyle to the build process (Part 2) === Pull Request #234 === PR title Issue 230: Add Checkstyle to the build process (Part 2) Commit title ISSUE #230: Add Checkstyle to the build process (Part 2) Source sigee/checkstyle2 Target master URL https://api.github.com/repos/apache/bookkeeper/pulls/234 Proceed with merging pull request #234? (y/n): y git fetch apache-github pull/234/head:PR_TOOL_MERGE_PR_234 remote: Counting objects: 87, done. remote: Compressing objects: 100% (12/12), done. remote: Total 87 (delta 69), reused 87 (delta 69), pack-reused 0 Unpacking objects: 100% (87/87), done. ... ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
